Alanxtl commented on code in PR #3695:
URL: https://github.com/apache/dubbo-go/pull/3695#discussion_r3841532568
##########
global/shutdown_config.go:
##########
@@ -76,7 +75,7 @@ type ShutdownConfig struct {
ProviderActiveCount atomic.Int32
// provider last received request timestamp
- ProviderLastReceivedRequestTime atomic.Time
+ ProviderLastReceivedRequestTime atomic.Pointer[time.Time]
Review Comment:
这两个就保持原来的样子吧 不改了
##########
registry/service_discovery.go:
##########
@@ -56,15 +55,15 @@ type ServiceDiscovery interface {
// GetInstancesByPage will return a page containing instances of
ServiceInstance
// with the serviceName the page will start at offset
- GetInstancesByPage(serviceName string, offset int, pageSize int)
gxpage.Pager
+ GetInstancesByPage(serviceName string, offset int, pageSize int) Pager
Review Comment:
这两个就保持原来的样子吧 不改了
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
