NeverENG commented on code in PR #3690:
URL: https://github.com/apache/dubbo-go/pull/3690#discussion_r3829908407
##########
go.mod:
##########
@@ -148,3 +148,10 @@ require (
gopkg.in/ini.v1 v1.66.2 // indirect
gopkg.in/yaml.v2 v2.4.0 // indirect
)
+
+// TODO(#3459): temporary local replace while dubbogo/gost's migration off the
+// forked github.com/dubbogo/go-zookeeper package (see feat/upstream-zk branch
+// of https://github.com/dubbogo/gost) is validated here. Remove this once a
+// released gost version with the upstream github.com/go-zookeeper/zk
+// dependency is published, and bump the `require` above accordingly.
+replace github.com/dubbogo/gost => github.com/NeverENG/gost
v0.0.0-20260821085803-e11b407c6b6a
Review Comment:
Fixed in 1b4cb878: now that dubbogo/gost#147 is merged, the `replace`
directive is dropped entirely and `require` points directly at the official
`github.com/dubbogo/gost` merge commit
(`v1.14.5-0.20260821091004-da8c3ce04178`). No fork reference remains in
go.mod/go.sum.
##########
config_center/zookeeper/impl_test.go:
##########
@@ -66,11 +66,11 @@ func TestGetPath(t *testing.T) {
}
func TestPublishAndRemoveConfigWithMockZk(t *testing.T) {
- cluster, client, _, err := gxzookeeper.NewMockZookeeperClient("test",
5e9)
+ client, _, err := gxzookeeper.NewZookeeperClientFromEnv("test", 5e9)
if err != nil {
t.Skipf("skip mock zk setup: %v", err)
}
Review Comment:
Fixed in ccbcc971: renamed the tests and their skip messages to drop "Mock"
— they run against a real ZooKeeper resolved from ZK_ADDR (default
127.0.0.1:2181).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
