AlexStocks commented on code in PR #3690:
URL: https://github.com/apache/dubbo-go/pull/3690#discussion_r3829370270
##########
config_center/zookeeper/impl_test.go:
##########
@@ -66,11 +66,11 @@ func TestGetPath(t *testing.T) {
}
func TestPublishAndRemoveConfigWithMockZk(t *testing.T) {
- cluster, client, _, err := gxzookeeper.NewMockZookeeperClient("test",
5e9)
+ client, _, err := gxzookeeper.NewZookeeperClientFromEnv("test", 5e9)
if err != nil {
t.Skipf("skip mock zk setup: %v", err)
Review Comment:
[P1] 默认 CI 中这两条迁移回归测试会静默跳过
仓库的 `github-actions.yml` 单元测试只运行 `make test`，没有启动 ZooKeeper，也没有设置
`ZK_ADDR`。在当前 Head 的 Linux 环境执行这两个测试时，它们都因 `127.0.0.1:2181` 不可达而 `SKIP`，但
package 仍返回 `PASS`。这里从内嵌 mock 改为外部服务后，PR 要验证的 publish/update/remove/read
行为因此不会在默认 CI 中执行，适配层的行为回归也能绿色合并。请在对应 CI job 中提供隔离的 ZooKeeper
并让连接失败成为失败，或保留可重复的本地 fixture；不要让覆盖本次迁移的测试依赖开发者机器环境后直接跳过。
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
