Oxidaner commented on code in PR #3293:
URL: https://github.com/apache/dubbo-go/pull/3293#discussion_r3090571317


##########
server/server.go:
##########
@@ -56,7 +57,11 @@ type Server struct {
        // key is interface name, value is *ServiceOptions
        interfaceNameServices map[string]*ServiceOptions
        // indicate whether the server is already started
-       serve bool
+       serve     bool
+       stopCh    chan struct{}
+       serveDone chan struct{}
+       stopOnce  sync.Once
+       stopperID uint64

Review Comment:
   graceful shutdown的主动通知是 通知长连接消费者“服务要下线了”
   现在这个主动通知 是将该进程里的 server 实例停掉



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to