Oxidaner commented on code in PR #3293:
URL: https://github.com/apache/dubbo-go/pull/3293#discussion_r3078101831
##########
server/server.go:
##########
@@ -56,7 +57,11 @@ type Server struct {
// key is interface name, value is *ServiceOptions
interfaceNameServices map[string]*ServiceOptions
// indicate whether the server is already started
- serve bool
+ serve bool
+ stopCh chan struct{}
+ serveDone chan struct{}
+ stopOnce sync.Once
+ stopperID uint64
Review Comment:
想做一个主动通知, 主动执行并等待每个 server 的 Stop(ctx) 完成. 再由 Done() 做保底 如果你觉得冗余我可以去掉
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]