Copilot commented on code in PR #704:
URL: https://github.com/apache/dubbo-go-pixiu/pull/704#discussion_r2221239792
##########
go.mod:
##########
@@ -37,38 +37,40 @@ require (
github.com/spf13/cobra v1.5.0
github.com/stretchr/testify v1.10.0
go.etcd.io/etcd/api/v3 v3.5.7
- go.opentelemetry.io/otel v1.10.0
- go.opentelemetry.io/otel/exporters/jaeger v1.10.0
+ go.opentelemetry.io/otel v1.15.1
+ go.opentelemetry.io/otel/exporters/jaeger v1.15.1
go.opentelemetry.io/otel/exporters/otlp/otlptrace v1.10.0
go.opentelemetry.io/otel/exporters/otlp/otlptrace/otlptracehttp v1.10.0
Review Comment:
The otlptrace dependency version v1.10.0 is inconsistent with other
OpenTelemetry dependencies that were updated to v1.15.1. Consider updating this
to v1.15.1 for consistency.
```suggestion
go.opentelemetry.io/otel/exporters/otlp/otlptrace v1.15.1
go.opentelemetry.io/otel/exporters/otlp/otlptrace/otlptracehttp v1.15.1
```
##########
go.mod:
##########
@@ -37,38 +37,40 @@ require (
github.com/spf13/cobra v1.5.0
github.com/stretchr/testify v1.10.0
go.etcd.io/etcd/api/v3 v3.5.7
- go.opentelemetry.io/otel v1.10.0
- go.opentelemetry.io/otel/exporters/jaeger v1.10.0
+ go.opentelemetry.io/otel v1.15.1
+ go.opentelemetry.io/otel/exporters/jaeger v1.15.1
go.opentelemetry.io/otel/exporters/otlp/otlptrace v1.10.0
go.opentelemetry.io/otel/exporters/otlp/otlptrace/otlptracehttp v1.10.0
go.opentelemetry.io/otel/exporters/prometheus v0.32.1
Review Comment:
The prometheus exporter version v0.32.1 appears inconsistent with the
updated OpenTelemetry core dependencies. Consider checking if a newer version
is available that's compatible with otel v1.15.1.
```suggestion
go.opentelemetry.io/otel/exporters/prometheus v1.15.1
```
##########
go.mod:
##########
@@ -37,38 +37,40 @@ require (
github.com/spf13/cobra v1.5.0
github.com/stretchr/testify v1.10.0
go.etcd.io/etcd/api/v3 v3.5.7
- go.opentelemetry.io/otel v1.10.0
- go.opentelemetry.io/otel/exporters/jaeger v1.10.0
+ go.opentelemetry.io/otel v1.15.1
+ go.opentelemetry.io/otel/exporters/jaeger v1.15.1
go.opentelemetry.io/otel/exporters/otlp/otlptrace v1.10.0
go.opentelemetry.io/otel/exporters/otlp/otlptrace/otlptracehttp v1.10.0
go.opentelemetry.io/otel/exporters/prometheus v0.32.1
- go.opentelemetry.io/otel/metric v0.32.1
- go.opentelemetry.io/otel/sdk v1.10.0
+ go.opentelemetry.io/otel/metric v0.34.0
+ go.opentelemetry.io/otel/sdk v1.15.1
go.opentelemetry.io/otel/sdk/metric v0.32.1
Review Comment:
The SDK metric dependency version v0.32.1 is inconsistent with the updated
metric dependency v0.34.0 on line 45. Consider updating this to match or ensure
version compatibility.
```suggestion
go.opentelemetry.io/otel/sdk/metric v0.34.0
```
##########
go.mod:
##########
@@ -37,38 +37,40 @@ require (
github.com/spf13/cobra v1.5.0
github.com/stretchr/testify v1.10.0
go.etcd.io/etcd/api/v3 v3.5.7
- go.opentelemetry.io/otel v1.10.0
- go.opentelemetry.io/otel/exporters/jaeger v1.10.0
+ go.opentelemetry.io/otel v1.15.1
+ go.opentelemetry.io/otel/exporters/jaeger v1.15.1
go.opentelemetry.io/otel/exporters/otlp/otlptrace v1.10.0
go.opentelemetry.io/otel/exporters/otlp/otlptrace/otlptracehttp v1.10.0
Review Comment:
The otlptracehttp dependency version v1.10.0 is inconsistent with other
OpenTelemetry dependencies that were updated to v1.15.1. Consider updating this
to v1.15.1 for consistency.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
