zrlw commented on code in PR #15529:
URL: https://github.com/apache/dubbo/pull/15529#discussion_r2191871590


##########
dubbo-rpc/dubbo-rpc-triple/src/main/java/org/apache/dubbo/rpc/protocol/tri/TriplePingPongHandler.java:
##########
@@ -29,21 +30,28 @@ public class TriplePingPongHandler extends 
ChannelDuplexHandler {
 
     private final long pingAckTimeout;
 
-    private ScheduledFuture<?> pingAckTimeoutFuture;
+    private final AtomicReference<ScheduledFuture<?>> pingAckTimeoutFutureRef 
= new AtomicReference<>();

Review Comment:
   the other reason is  the IdleStateEvent is triggered by 
ReaderIdleTimeoutTask of IdleStateHandler, the userEventTriggered  method of 
TriplePingPongHandler will be called by the task thread.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to