zrlw opened a new pull request, #15529:
URL: https://github.com/apache/dubbo/pull/15529

   ## What is the purpose of the change?
   ```
   private void pingAck(ChannelHandlerContext ctx) {
           ChannelPipeline pipeline = ctx.channel().parent().pipeline();
           pipeline.fireChannelRead(new DefaultHttp2PingFrame(0, true));
           pipeline.fireChannelReadComplete();
   ```
   will break Netty event handling process.
   ```pipeline.fireChannelRead(new DefaultHttp2PingFrame(0, true));``` will set 
reading status of IdleStateHandler to true,
   ```pipeline.fireChannelReadComplete()``` will set read completed status no 
matter whether current channel handler context finish reading or not.
   ## Checklist
   - [x] Make sure there is a 
[GitHub_issue](https://github.com/apache/dubbo/issues) field for the change.
   - [x] Write a pull request description that is detailed enough to understand 
what the pull request does, how, and why.
   - [x] Write necessary unit-test to verify your logic correction. If the new 
feature or significant change is committed, please remember to add sample in 
[dubbo samples](https://github.com/apache/dubbo-samples) project.
   - [x] Make sure gitHub actions can pass. [Why the workflow is failing and 
how to fix it?](../CONTRIBUTING.md)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to