Copilot commented on code in PR #76:
URL:
https://github.com/apache/dubbo-go-pixiu-samples/pull/76#discussion_r2173633311
##########
dubbogo/simple/nacos_farconf/docker/docker-compose.yml:
##########
@@ -20,18 +20,17 @@
version: '3'
services:
- zookeeper:
- image: zookeeper
- ports:
- - 2181:2181
- restart: on-failure
nacos:
- image: nacos/nacos-server:2.0.1
+ image: nacos/nacos-server:v2.5.1
container_name: nacos-standalone
environment:
- PREFER_HOST_MODE=hostname
- MODE=standalone
+# - NACOS_AUTH_ENABLE=false
- NACOS_AUTH_ENABLE=true
+ - NACOS_AUTH_TOKEN=DboQPxIongllAOHCyap9JiuJQ0sqHgh+31QQe4+17cM=
Review Comment:
Hard-coded authentication token in source; consider sourcing secrets from
environment variables or a secure vault to avoid committing sensitive
credentials.
```suggestion
- NACOS_AUTH_TOKEN=${NACOS_AUTH_TOKEN}
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
