Alanxtl opened a new pull request, #679: URL: https://github.com/apache/dubbo-go-pixiu/pull/679
<!-- Thanks for sending a pull request! --> **What this PR does**: 1. refactors the creation of the Nacos client configuration in `configcenter/nacos_load.go` to use a builder pattern for improved readability and maintainability. 2. add `username` and `password` field when creating nacos client, which enables pixiu to get config from a authorization needed nacos server. If not add this two fields, pixiu always get panic when trying to get config from a authorization needed nacos server when starting. 3. fix: `bootstrap.Nacos.DataId` and `bootstrap.Nacos.Group` fields are passed in when pixiu tries gets the remote config from nacos. These two fields are used to specify the id and group of the request. These two fields are defined, but were not passed in the previous implementation, so the default value was always used instead of the actual configuration value. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
