Alanxtl commented on code in PR #2906:
URL: https://github.com/apache/dubbo-go/pull/2906#discussion_r2119057521
##########
filter/graceful_shutdown/provider_filter.go:
##########
@@ -90,11 +91,16 @@ func (f *providerGracefulShutdownFilter) OnResponse(ctx
context.Context, result
func (f *providerGracefulShutdownFilter) Set(name string, conf any) {
switch name {
case constant.GracefulShutdownFilterShutdownConfig:
- if shutdownConfig, ok := conf.(*config.ShutdownConfig); ok {
+ if shutdownConfig, ok := conf.(*global.ShutdownConfig); ok {
f.shutdownConfig = shutdownConfig
return
}
- logger.Warnf("the type of config for {%s} should be
*config.ShutdownConfig", constant.GracefulShutdownFilterShutdownConfig)
+ // only for compatibility with old config, able to directly
remove after config is deleted
Review Comment:
done
##########
filter/graceful_shutdown/consumer_filter.go:
##########
@@ -76,11 +77,16 @@ func (f *consumerGracefulShutdownFilter) OnResponse(ctx
context.Context, result
func (f *consumerGracefulShutdownFilter) Set(name string, conf any) {
switch name {
case constant.GracefulShutdownFilterShutdownConfig:
- if shutdownConfig, ok := conf.(*config.ShutdownConfig); ok {
+ if shutdownConfig, ok := conf.(*global.ShutdownConfig); ok {
Review Comment:
done
##########
config/graceful_shutdown.go:
##########
@@ -55,19 +55,19 @@ const defaultShutDownTime = time.Second * 60
func gracefulShutdownInit() {
// retrieve ShutdownConfig for gracefulShutdownFilter
- cGracefulShutdownFilter, existcGracefulShutdownFilter :=
extension.GetFilter(constant.GracefulShutdownConsumerFilterKey)
+ consumerGracefulShutdownFilter, existcGracefulShutdownFilter :=
extension.GetFilter(constant.GracefulShutdownConsumerFilterKey)
if !existcGracefulShutdownFilter {
return
}
- sGracefulShutdownFilter, existsGracefulShutdownFilter :=
extension.GetFilter(constant.GracefulShutdownProviderFilterKey)
+ providerGracefulShutdownFilter, existsGracefulShutdownFilter :=
extension.GetFilter(constant.GracefulShutdownProviderFilterKey)
Review Comment:
done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
