Alanxtl commented on code in PR #2906:
URL: https://github.com/apache/dubbo-go/pull/2906#discussion_r2119024960
##########
graceful_shutdown/options.go:
##########
@@ -65,11 +65,11 @@ func WithConsumerUpdateWaitTime(duration time.Duration)
Option {
}
// todo(DMwangnima): add more specified configuration API
-//func WithRejectRequestHandler(handler string) Option {
-// return func(opts *Options) {
-// opts.Shutdown.RejectRequestHandler = handler
-// }
-//}
+func WithRejectRequestHandler(handler string) Option {
Review Comment:
if we wan't to use options to set `regecthandler`, the code is like this:
```go
graceful_shutdown.NewOptions(
graceful_shutdown.WithRejectRequestHandler("test"),
)
```
so we need `WithRejectRequestHandler`to set handler
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
