AlexStocks commented on PR #2886: URL: https://github.com/apache/dubbo-go/pull/2886#issuecomment-2894589649
> ## Pull Request Overview > This PR updates the client filter registration to use the new `overallReference` grouping. > > * Reassigns `WithClientFilter` to set the filter on `overallReference` instead of `Consumer`. > * Updates the corresponding test to verify the filter on `cli.cliOpts.overallReference.Filter`. > > ### Reviewed Changes > Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments. > > File Description > client/options.go Changed `WithClientFilter` to assign `filter` to `opts.overallReference.Filter`. > client/options_test.go Updated test assertion to check `cli.cliOpts.overallReference.Filter` instead of `Consumer.Filter`. > Comments suppressed due to low confidence (2) > **client/options.go:546** > > * The TODO about moving the Filter Option to overallReference has been addressed; please remove or update this comment to keep the codebase clean. > > ``` > // todo(DMwangnima): change Filter Option like Cluster and LoadBalance > ``` > > **client/options.go:549** > > * [nitpick] The field name `overallReference` is somewhat ambiguous. Consider renaming it to `ReferenceOptions` or `FilterReference` to align with other option-group naming patterns and improve clarity. > > ``` > opts.overallReference.Filter = filter > ``` @Whitea029 Please check copilot’s comment whether they are usefull or not. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
