marsevilspirit commented on code in PR #2886:
URL: https://github.com/apache/dubbo-go/pull/2886#discussion_r2097989509
##########
client/options.go:
##########
@@ -543,11 +543,10 @@ func WithClientURL(url string) ClientOption {
}
}
-// todo(DMwangnima): change Filter Option like Cluster and LoadBalance
func WithClientFilter(filter string) ClientOption {
return func(opts *ClientOptions) {
- // todo: move this to overallReference
opts.Consumer.Filter = filter
Review Comment:
I think we could remove this consumer filter line.
Just set overallReference filter.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
