rnewson commented on code in PR #5628:
URL: https://github.com/apache/couchdb/pull/5628#discussion_r2330634760
##########
src/nouveau/src/nouveau_plugin_couch_db.erl:
##########
@@ -13,10 +13,46 @@
-module(nouveau_plugin_couch_db).
-export([
+ before_doc_update/3,
is_valid_purge_client/2,
on_compact/2
]).
+-include("nouveau.hrl").
+-include_lib("couch/include/couch_db.hrl").
+
+%% New index definitions get an explicit lucene version property, if missing.
+before_doc_update(
Review Comment:
I've tried to consider various manual shenanigans while trying to make the
Java side stick to a "the version of Lucene I am using now plus the one before"
without hardcoding "10" and "9" everywhere. I will review that aspect again as
I think there are gaps (e.g, I want it to be an error to set lucene_version to
anything but `10` or `9` and have that handled well (i.e, no stack traces, no
erlang process crashes, just an error message in the log or in the http
response)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
