nickva commented on code in PR #5628:
URL: https://github.com/apache/couchdb/pull/5628#discussion_r2330515383


##########
src/nouveau/src/nouveau_plugin_couch_db.erl:
##########
@@ -13,10 +13,46 @@
 -module(nouveau_plugin_couch_db).
 
 -export([
+    before_doc_update/3,
     is_valid_purge_client/2,
     on_compact/2
 ]).
 
+-include("nouveau.hrl").
+-include_lib("couch/include/couch_db.hrl").
+
+%% New index definitions get an explicit lucene version property, if missing.
+before_doc_update(

Review Comment:
   This is a neat approach.
   
   Wonder what would happen if users would toggle the version by hand (bump it 
up, down, make it a non-integer) or just remove it after it was created? Would 
that break the index or crash anything?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to