>From Ali Alsuliman <ali.al.solai...@gmail.com>:

Attention is currently required from: Ritik Raj.
Ali Alsuliman has posted comments on this change. ( 
https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/20108 )

Change subject: [ASTERIXDB-3601][FUNC] Added column-count function
......................................................................


Patch Set 4:

(3 comments)

File 
asterixdb/asterix-app/src/main/java/org/apache/asterix/app/message/EstimateColumnCountRequestMessage.java:

https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/20108/comment/f738f213_41dbcfce
PS4, Line 38: EstimateColumnCountRequestMessage
I think we should make these messages whispered so that they are not printed in 
the logs


https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/20108/comment/f2ae8a2f_53fe1048
PS4, Line 43: //DatasetPartition contains more than required information.
Do we want to exclude those secondary index factories?


File 
asterixdb/asterix-app/src/main/java/org/apache/asterix/utils/StorageUtil.java:

https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/20108/comment/ea51b0f3_29676019
PS4, Line 134: f (dataset.getDatasetType() != DatasetConfig.DatasetType.INTERNAL
             :                     || 
dataset.getDatasetFormatInfo().getFormat() != 
DatasetConfig.DatasetFormat.COLUMN) {
Can we split this into two and make the error message along the lines of:
"Retrieving estimated column count is not applicable to %1$s".
You pass either:
- "collection type: " + dataset.getDatasetType().
- "storage format type: " + dataset.getDatasetFormatInfo().getFormat().

It's just to display EXTERNAL collections without mentioning the storage type 
for them.



--
To view, visit https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/20108
To unsubscribe, or for help writing mail filters, visit 
https://asterix-gerrit.ics.uci.edu/settings

Gerrit-Project: asterixdb
Gerrit-Branch: ionic
Gerrit-Change-Id: Id7ce0662811ce72c882de08fbd2c0964f88d3dd4
Gerrit-Change-Number: 20108
Gerrit-PatchSet: 4
Gerrit-Owner: Ritik Raj <ritik....@couchbase.com>
Gerrit-Reviewer: Jenkins <jenk...@fulliautomatix.ics.uci.edu>
Gerrit-Reviewer: Peeyush Gupta <peeyush.gu...@couchbase.com>
Gerrit-CC: Ali Alsuliman <ali.al.solai...@gmail.com>
Gerrit-CC: Anon. E. Moose #1000171
Gerrit-Attention: Ritik Raj <ritik....@couchbase.com>
Gerrit-Comment-Date: Thu, 24 Jul 2025 01:54:00 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment

Reply via email to