>From Peeyush Gupta <peeyush.gu...@couchbase.com>: Attention is currently required from: Ritik Raj. Peeyush Gupta has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/20108 )
Change subject: [ASTERIXDB-3601][FUNC] Added column-count function ...................................................................... Patch Set 4: (3 comments) File asterixdb/asterix-app/src/main/java/org/apache/asterix/app/function/collectioncolumncount/CollectionEstimateColumnCountRewriter.java: https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/20108/comment/60ac7c1f_0750b9ec PS4, Line 64: function.getArguments().size() < 3 || function.getArguments().size() > 4 Do you mean function.getArguments().size() != 3 or can function arguments can be 4 as well? File asterixdb/asterix-app/src/main/java/org/apache/asterix/app/message/EstimateColumnCountRequestMessage.java: https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/20108/comment/4703f46c_eb6d508d PS4, Line 72: failed to get collection size failed to get column count https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/20108/comment/ddbb213f_45b42e5c PS4, Line 84: failed to send collection size to cc failed to send column count to cc -- To view, visit https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/20108 To unsubscribe, or for help writing mail filters, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: ionic Gerrit-Change-Id: Id7ce0662811ce72c882de08fbd2c0964f88d3dd4 Gerrit-Change-Number: 20108 Gerrit-PatchSet: 4 Gerrit-Owner: Ritik Raj <ritik....@couchbase.com> Gerrit-Reviewer: Jenkins <jenk...@fulliautomatix.ics.uci.edu> Gerrit-CC: Ali Alsuliman <ali.al.solai...@gmail.com> Gerrit-CC: Anon. E. Moose #1000171 Gerrit-CC: Peeyush Gupta <peeyush.gu...@couchbase.com> Gerrit-Attention: Ritik Raj <ritik....@couchbase.com> Gerrit-Comment-Date: Tue, 22 Jul 2025 20:34:13 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment
