ctubbsii commented on code in PR #5749:
URL: https://github.com/apache/accumulo/pull/5749#discussion_r2323902726
##########
server/base/src/main/java/org/apache/accumulo/server/ServerContext.java:
##########
@@ -182,6 +191,10 @@ public SiteConfiguration getSiteConfiguration() {
@Override
public AccumuloConfiguration getConfiguration() {
+ return serverConfFactory.get().getResourceGroupConfiguration();
Review Comment:
I think my question wasn't clear. I'm asking, when would we ever want to
return just the SystemConfiguration, not flavored by the resource group config?
If we never do, then we didn't need to add
ServerConfigurationFactory.getResourceGroupConfiguration. Instead, we could
have just made getSystemConfiguration return the resource group configuration.
We don't really need both methods on the factory, because there's never a
situation where we're just asking for the raw SystemConfiguration... because
everything is in a resource group, even if it's the default resource group.
However, I think that while it is true that everything exists in a resource
group, even if it's the default resource group, we still want to keep these
separate, so we can power the APIs/utilities that query the config. We'll
probably want to query them separately.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
