dlmarion commented on code in PR #5749:
URL: https://github.com/apache/accumulo/pull/5749#discussion_r2318840307
##########
server/base/src/main/java/org/apache/accumulo/server/ServerContext.java:
##########
@@ -182,6 +191,10 @@ public SiteConfiguration getSiteConfiguration() {
@Override
public AccumuloConfiguration getConfiguration() {
+ return serverConfFactory.get().getResourceGroupConfiguration();
Review Comment:
> Is there ever a situation where this wouldn't apply? Or is everything
using ServerContext using the default resource group?
The ServerConfigurationFactory is created using the ResourceGroupId of the
server process. It should return the ResourceGroupConfiguration for the
configured resource group, it should not always be default.
> Also one note about the default resource group... it seems to be a
convention, but not necessarily strictly protected (e.g. can you delete the
default resource group?)
`ManagerClientServiceHandler.removeResourceGroupNode` throws an exception if
the default resource group is passed as an argument.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
