keith-turner commented on code in PR #5863:
URL: https://github.com/apache/accumulo/pull/5863#discussion_r2323570702
##########
server/tserver/src/main/java/org/apache/accumulo/tserver/tablet/Tablet.java:
##########
@@ -1523,7 +1525,18 @@ public Optional<SplitComputations>
getSplitComputations() {
lastSplitComputation = new SoftReference<>(newComputation);
} catch (IOException e) {
lastSplitComputation.clear();
- log.error("Failed to compute split information from files " +
e.getMessage());
+ if (e.getMessage().contains("File does not exist")) {
+ Set<TabletFile> currentFiles = getDatafileManager().getFiles();
+ Sets.SetView<TabletFile> missingFiles = Sets.difference(files,
currentFiles);
+ if (!missingFiles.isEmpty()) {
+ log.warn(
Review Comment:
This could be debug or info, its an expected case.
##########
server/tserver/src/main/java/org/apache/accumulo/tserver/tablet/Tablet.java:
##########
@@ -1523,7 +1525,18 @@ public Optional<SplitComputations>
getSplitComputations() {
lastSplitComputation = new SoftReference<>(newComputation);
} catch (IOException e) {
lastSplitComputation.clear();
- log.error("Failed to compute split information from files " +
e.getMessage());
+ if (e.getMessage().contains("File does not exist")) {
Review Comment:
Instead of looking at the exception, maybe could just look to see if the
tablets set of files changed like its doing below for logging. Except also use
this to determine how to log.
##########
server/tserver/src/main/java/org/apache/accumulo/tserver/tablet/Tablet.java:
##########
@@ -1507,6 +1508,7 @@ public Optional<SplitComputations> getSplitComputations()
{
// Only want one thread doing this computation at time for a tablet.
if (splitComputationLock.tryLock()) {
try {
+ log.debug("Starting midpoint calculation");
Review Comment:
Could include the extent in the log message.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
