ctubbsii commented on code in PR #5863:
URL: https://github.com/apache/accumulo/pull/5863#discussion_r2323165647
##########
server/tserver/src/main/java/org/apache/accumulo/tserver/tablet/Tablet.java:
##########
@@ -1523,7 +1525,18 @@ public Optional<SplitComputations>
getSplitComputations() {
lastSplitComputation = new SoftReference<>(newComputation);
} catch (IOException e) {
lastSplitComputation.clear();
- log.error("Failed to compute split information from files " +
e.getMessage());
+ if (e.getMessage().contains("File does not exist")) {
Review Comment:
Can we check the class type instead of the string message, which could be
localized.
```suggestion
if (e.getMessage().contains("File does not exist")) {
```
##########
server/tserver/src/main/java/org/apache/accumulo/tserver/tablet/Tablet.java:
##########
@@ -1523,7 +1525,18 @@ public Optional<SplitComputations>
getSplitComputations() {
lastSplitComputation = new SoftReference<>(newComputation);
} catch (IOException e) {
lastSplitComputation.clear();
- log.error("Failed to compute split information from files " +
e.getMessage());
+ if (e.getMessage().contains("File does not exist")) {
+ Set<TabletFile> currentFiles = getDatafileManager().getFiles();
+ Sets.SetView<TabletFile> missingFiles = Sets.difference(files,
currentFiles);
+ if (!missingFiles.isEmpty()) {
+ log.warn(
+ "Failed to compute spit information. The following files have
been removed: {}",
Review Comment:
Typo: split
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
