dlmarion commented on code in PR #5605:
URL: https://github.com/apache/accumulo/pull/5605#discussion_r2121513632


##########
core/src/main/java/org/apache/accumulo/core/clientImpl/ClientContext.java:
##########
@@ -242,11 +242,11 @@ public ClientContext(SingletonReservation reservation, 
ClientInfo info,
     } else {
       // Provide a default UEH that just logs the error
       if (ueh == null) {
-        clientThreadPools = ThreadPools.getClientThreadPools((t, e) -> {
+        clientThreadPools = ThreadPools.getClientThreadPools(serverConf, (t, 
e) -> {

Review Comment:
   I had to revert these changes at they caused Spotbugs to fail with:
   
   ```
   [ERROR] High: serverConfFactory isn't initialized in 
org.apache.accumulo.server.ServerContext.getConfiguration() when invoked from 
constructor for superclass [org.apache.accumulo.core.clientImpl.ClientContext, 
org.apache.accumulo.server.ServerContext, 
org.apache.accumulo.server.ServerContext] Call from superclass constructor at 
ClientContext.java:[line 249]Field set (too late) at ServerContext.java:[line 
122]At ServerContext.java:[line 162] 
UR_UNINIT_READ_CALLED_FROM_SUPER_CONSTRUCTOR
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to