dlmarion commented on code in PR #5605:
URL: https://github.com/apache/accumulo/pull/5605#discussion_r2121462812


##########
core/src/main/java/org/apache/accumulo/core/classloader/DefaultContextClassLoaderFactory.java:
##########
@@ -74,7 +74,7 @@ private static void 
setContextConfig(Supplier<Map<String,String>> contextConfigS
   private static void startCleanupThread(final AccumuloConfiguration conf,
       final Supplier<Map<String,String>> contextConfigSupplier) {
     ScheduledFuture<?> future =
-        ((ScheduledThreadPoolExecutor) ThreadPools.getClientThreadPools((t, e) 
-> {
+        ((ScheduledThreadPoolExecutor) ThreadPools.getClientThreadPools(conf, 
(t, e) -> {

Review Comment:
   This implements 
`org.apache.accumulo.core.spi.common.ContextClassLoaderFactory`, part of the 
SPI, so can't push down the context.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to