ddanielr commented on code in PR #5455:
URL: https://github.com/apache/accumulo/pull/5455#discussion_r2031728108
##########
shell/src/main/java/org/apache/accumulo/shell/commands/MergeCommand.java:
##########
@@ -95,11 +95,9 @@ public Options getOptions() {
new Option("s", "size", true, "merge tablets to the given size over
the entire table");
forceOpt = new Option("f", "force", false,
"merge small tablets to large tablets, even if it goes over the given
size");
- // Using the constructor does not allow for empty option
- Option.Builder builder = Option.builder().longOpt("all").hasArg(false)
Review Comment:
Do we really need to decide which option string to check for?
CommandLine has a `hasOption` method that takes the entire `Option` object
instead of choosing between the `short` and `long` opt values.
https://commons.apache.org/proper/commons-cli/apidocs/org/apache/commons/cli/CommandLine.html#hasOption(Option)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
