keith-turner commented on code in PR #5455:
URL: https://github.com/apache/accumulo/pull/5455#discussion_r2031786006
##########
shell/src/main/java/org/apache/accumulo/shell/commands/MergeCommand.java:
##########
@@ -95,11 +95,9 @@ public Options getOptions() {
new Option("s", "size", true, "merge tablets to the given size over
the entire table");
forceOpt = new Option("f", "force", false,
"merge small tablets to large tablets, even if it goes over the given
size");
- // Using the constructor does not allow for empty option
- Option.Builder builder = Option.builder().longOpt("all").hasArg(false)
Review Comment:
> I wonder if all the code should use this and if it means some of the
existing code is not handling long options properly. Like will only the -f
options work for the merge command and not the --force option?
Looked into this and it seems to work. When `-f` string is passed to CLI
code it will use that to find the Option object and would still match if
`--force` was passed in, but that only works when there is a short option.
Still seems better to just pass the option object though.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
