ctubbsii commented on code in PR #5460:
URL: https://github.com/apache/accumulo/pull/5460#discussion_r2036297063
##########
server/manager/src/main/java/org/apache/accumulo/manager/tableOps/bulkVer2/LoadFiles.java:
##########
@@ -504,12 +504,15 @@ static long loadFiles(Loader loader, BulkInfo bulkInfo,
Path bulkDir,
}
long sleepTime = loader.finish();
- if (sleepTime > 0) {
- log.trace("{}: Tablet Max Sleep is {}", fmtTid, sleepTime);
- long scanTime = Math.min(totalProcessingTime.toMillis(), 30_000);
- log.trace("{}: Scan time is {}", fmtTid, scanTime);
- sleepTime = Math.max(sleepTime, scanTime * 2);
+ if (sleepTime <= 1) {
+ log.trace("{}: Sleeping for {}ms", fmtTid, sleepTime);
+ return sleepTime;
}
+
Review Comment:
The content of this block is duplicated below. I think the equivalent change
would have kept the previous if statement, and just changed it to the
following, rather than duplicate the last two lines.
```java
if (sleepTime > 1) {
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
