ctubbsii commented on PR #5460: URL: https://github.com/apache/accumulo/pull/5460#issuecomment-2791226312
I'm having a hard time understanding how these changes match the description: `Skips the sleep calculation when bulkv2 reports that it has waited for all tablet servers to respond.` or `Reduce sleep time for finished bulkv2 jobs` It seems like the only substantive change was the change from `> 0` to (effectively) `> 1`, so it only skips computing a new sleepTime when it is exactly 1 (it was already skipped when it was 0). Does the value of `1` have special meaning? If so, I think there's a simpler to change to just change to `> 1` and add a small comment explaining why we're skipping when it's that particular value. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
