keith-turner commented on PR #5341: URL: https://github.com/apache/accumulo/pull/5341#issuecomment-2761525555
I like the name `limitedSearch`. For the javadoc I was not sure what limit related to, it could either relate to the number of elements that will be inspected or the number of times next will be called. Those two things seem to be off by one, like if I inspect N elements I will call next() N-1 times. Would be good to make the javadoc declare which of those two its limiting, not sure it matters which one. I arbitrarily chose the number of times next() is called and tried to make the code follow the javadoc. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
