keith-turner commented on code in PR #5341:
URL: https://github.com/apache/accumulo/pull/5341#discussion_r2010825518
##########
server/manager/src/main/java/org/apache/accumulo/manager/tableOps/bulkVer2/PrepBulkImport.java:
##########
@@ -116,82 +120,111 @@ private static boolean equals(Function<KeyExtent,Text>
extractor, KeyExtent ke1,
*/
@VisibleForTesting
static KeyExtent validateLoadMapping(String tableId, LoadMappingIterator lmi,
- TabletIterFactory tabletIterFactory, int maxNumTablets, long tid) throws
Exception {
+ TabletIterFactory tabletIterFactory, int maxNumTablets, long tid, int
skip) throws Exception {
+
var currRange = lmi.next();
Text startRow = currRange.getKey().prevEndRow();
Iterator<KeyExtent> tabletIter = tabletIterFactory.newTabletIter(startRow);
+ PeekingIterator<KeyExtent> pi = new PeekingIterator<>(tabletIter);
Review Comment:
Does not seem there is a need to keep the tabletIter separately from pi,
could collapse them and one variable.
```suggestion
PeekingIterator<KeyExtent> tabletIter = new
PeekingIterator<>(tabletIterFactory.newTabletIter(startRow));
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
