ctubbsii commented on code in PR #5419:
URL: https://github.com/apache/accumulo/pull/5419#discussion_r2006181178
##########
server/manager/src/main/java/org/apache/accumulo/manager/Manager.java:
##########
@@ -1146,14 +1139,9 @@ public void run() {
managerClientHandler = new ManagerClientServiceHandler(this);
compactionCoordinator = new CompactionCoordinator(context, security,
fateRefs, this);
- // Start the Manager's Client service
- // Ensure that calls before the manager gets the lock fail
- ManagerClientService.Iface haProxy =
- HighlyAvailableServiceWrapper.service(managerClientHandler, this);
Review Comment:
To close the loop on my question about why we care that a client talks to
the restarted server: it's because the restarted server may not be fully up
yet. So, we need to not just avoid advertising until the server is up and
ready, but we also need to wait until the restarted server is fully up and
ready before we allow clients to talk to it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
