dlmarion commented on code in PR #5419:
URL: https://github.com/apache/accumulo/pull/5419#discussion_r2005598857
##########
server/manager/src/main/java/org/apache/accumulo/manager/Manager.java:
##########
@@ -1146,14 +1139,9 @@ public void run() {
managerClientHandler = new ManagerClientServiceHandler(this);
compactionCoordinator = new CompactionCoordinator(context, security,
fateRefs, this);
- // Start the Manager's Client service
- // Ensure that calls before the manager gets the lock fail
- ManagerClientService.Iface haProxy =
- HighlyAvailableServiceWrapper.service(managerClientHandler, this);
Review Comment:
So, I think the solution here is to modify TServerUtils to **not** start the
Thrift TServer and instead do it in each of the server processes. The relevant
portion of code that needs to be removed from TServerUtils and maybe put into
ServerAddress is:
https://github.com/apache/accumulo/blob/d1ea90fa8503fc31a6bedb1d267e38debb18106d/server/base/src/main/java/org/apache/accumulo/server/rpc/TServerUtils.java#L656-L671
For most server processes, they would start the TServer right after creating
it. For the Manager, it could wait until all of the dependencies are started.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
