Everything looks fine so far, just a couple of comments: 1.- There is a setup.py missing for the sample plugin (it existed before). Nothing necessary. 2.- Now, having all setupX.py at the same dir, if you build and install one, and then, build/install a second one, without cleaning the first, the second install also installs the files from the first one, cause every build happens in the same dir. It can be easy solved using a --build-base parameter for each one, but it's not as straight as in "python setup_xX.py install"
Ghe Rivero On Thu, Nov 24, 2011 at 7:28 AM, ghe. rivero <ghe.riv...@gmail.com> wrote: > Wow! That was quick! I'll take a look this morning. > > Ghe Rivero > > > On Thu, Nov 24, 2011 at 2:36 AM, Brad Hall <b...@nicira.com> wrote: > >> Thanks for the feedback.. Here is a review for the changes: >> https://review.openstack.org/#change,1886 >> >> Thanks, >> Brad >> >> On Wed, Nov 23, 2011 at 2:28 PM, Chris Wright <chr...@sous-sol.org> >> wrote: >> > * Dan Wendlandt (d...@nicira.com) wrote: >> >> On Wed, Nov 23, 2011 at 2:03 PM, ghe. rivero <ghe.riv...@gmail.com> >> wrote: >> >> > Absolutly. I only hope that the change happens not so close to the >> final >> >> > essex release. Anyway, if you need a hand, I'm willing to help. >> >> >> >> I think this is key. Let's really focus on getting these changes in >> for >> >> essex-2 so people can have packaging solidified well in advanced of the >> >> main essex release. >> > >> > Agreed. And happy to help out here too. >> > >> > thanks, >> > -chris >> > >> > -- >> > Mailing list: https://launchpad.net/~netstack >> > Post to : netstack@lists.launchpad.net >> > Unsubscribe : https://launchpad.net/~netstack >> > More help : https://help.launchpad.net/ListHelp >> > >> >> -- >> Mailing list: https://launchpad.net/~netstack >> Post to : netstack@lists.launchpad.net >> Unsubscribe : https://launchpad.net/~netstack >> More help : https://help.launchpad.net/ListHelp >> > > > > -- > .''`. Pienso, Luego Incordio > : :' : > `. `' > `- www.debian.org www.hispalinux.es > > GPG Key: 26F020F7 > GPG fingerprint: 4986 39DA D152 050B 4699 9A71 66DB 5A36 26F0 20F7 > -- .''`. Pienso, Luego Incordio : :' : `. `' `- www.debian.org www.hispalinux.es GPG Key: 26F020F7 GPG fingerprint: 4986 39DA D152 050B 4699 9A71 66DB 5A36 26F0 20F7
-- Mailing list: https://launchpad.net/~netstack Post to : netstack@lists.launchpad.net Unsubscribe : https://launchpad.net/~netstack More help : https://help.launchpad.net/ListHelp
