Yes, I agree with that. I was going to email jeblair about this once the change went in.
Thanks, Brad On Tue, Oct 18, 2011 at 8:30 AM, Salvatore Orlando <salvatore.orla...@eu.citrix.com> wrote: > Hi Brad, > Thanks for this very important piece of code. > I think we should also try and enforce coverage checks in Jenkins (e.g.: if > coverage for a module drops below 80% reject commit). What's your opinion? > > Salvatore > >> -----Original Message----- >> From: netstack- >> bounces+salvatore.orlando=eu.citrix....@lists.launchpad.net >> [mailto:netstack- >> bounces+salvatore.orlando=eu.citrix....@lists.launchpad.net] On Behalf Of >> Brad Hall >> Sent: 18 October 2011 07:11 >> To: netstack@lists.launchpad.net >> Subject: [Netstack] Code coverage status >> >> Hey Everyone, >> >> After this change goes in (https://review.openstack.org/#change,677 >> [1]), you'll be able to generate code coverage numbers for our tests by using >> run_tests.sh -c. We're actually doing fairly good so far (sorry, gmail >> screws up >> the font): >> >> >> Name Stmts Miss Cover Missing >> ------------------------------------------------------------- >> quantum 0 0 100% >> quantum.api 28 0 100% >> quantum.api.api_common 47 0 100% >> quantum.api.attachments 48 6 88% 63-64, 74-77 >> quantum.api.faults 43 0 100% >> quantum.api.networks 65 1 98% 143 >> quantum.api.ports 83 4 95% 126-127, 134-135 >> quantum.api.views 0 0 100% >> quantum.api.views.attachments 10 0 100% >> quantum.api.views.networks 23 1 96% 58 >> quantum.api.views.ports 13 0 100% >> quantum.cli_lib 172 36 79% 86, 141-154, >> 184-185, 196-197, 210-211, 224-225, 237-238, 251-252, 264-266, 287-288, 302- >> 303, 317-318, 330-331 >> quantum.client 146 14 90% 123-126, >> 132-135, 156, 164, 174, 188, 208-210, 232 >> quantum.common 0 0 100% >> quantum.common.config 112 75 33% 62-64, 74-90, >> 100-120, 131-179, 203-218, 248, 253-254, 283-284, 291-308 >> quantum.common.exceptions 74 19 74% 55-61, 71-73, 159-170 >> quantum.common.extensions 269 33 88% 69, 77, 85, 93, >> 102, 110-111, 119-120, 128-129, 137, 209, 212, 272-274, 338-343, 367-370, >> 379- >> 382, 391-394, 439-443, 446-447, 459 >> quantum.common.flags 135 67 50% 52-91, 94-97, >> 101, 104, 107, 113-122, 127, 130-132, 135-142, 153, 156-160, 182, 201, 203, >> 237- >> 240 >> quantum.common.utils 118 79 33% 51, 64-69, >> 79-81, 86-91, 95-103, 107-127, 131, 138-147, 152-153, 157-161, 168, 174-176, >> 180, 184-186, 190, 194-196, 203-205, 208-223, 226-227 >> quantum.common.wsgi 243 66 73% 44-45, 48, >> 53-54, 61, 65-66, 70-73, 77-78, 102, 106, 110-114, 136, 181, 217, 228-241, >> 249- >> 254, 267, 373-374, 413-414, 439-440, 497, 501-506, 509-512, 519-526 >> quantum.db 0 0 100% >> quantum.db.api 136 11 92% 79-80, 94, >> 155-156, 196, 219, 226, 261, 266-267 >> quantum.db.models 51 13 75% 41, 44-45, >> 48-49, 53-54, 59-63, 84, 103 >> quantum.manager 36 5 86% 44, 56, 59, 61, 66 >> quantum.plugins 0 0 100% >> quantum.plugins.SamplePlugin 140 19 86% 43, 50, 57, 64, >> 71, 78, 84, 93, 99, 106, 113, 120, 125, 154, 166, 223, 299-300, 316 >> quantum.quantum_plugin_base 47 14 70% 54, 70, 85, 103, >> 120, 139, 153, 169, 187, 206, 220, 232, 258, 260 >> quantum.utils 57 33 42% 43-49, 54-59, 63-80, >> 86-88 >> ------------------------------------------------------------- >> TOTAL 2096 496 76% >> ---------------------------------------------------------------------- >> Ran 233 tests in 5.387s >> >> Thanks, >> Brad >> >> [1] Need another +1 for the review, btw. >> >> -- >> Mailing list: https://launchpad.net/~netstack >> Post to : netstack@lists.launchpad.net >> Unsubscribe : https://launchpad.net/~netstack >> More help : https://help.launchpad.net/ListHelp > -- Mailing list: https://launchpad.net/~netstack Post to : netstack@lists.launchpad.net Unsubscribe : https://launchpad.net/~netstack More help : https://help.launchpad.net/ListHelp
