Done on the first count, not on the second J...thanks for pointing it out...
From: Dan Wendlandt [mailto:d...@nicira.com] Sent: Friday, August 26, 2011 1:38 AM To: Sumit Naiksatam (snaiksat) Cc: Salvatore Orlando; netstack@lists.launchpad.net Subject: Re: [Netstack] D-4 drop delayed: cli appears broken in trunk On Fri, Aug 26, 2011 at 1:32 AM, Sumit Naiksatam (snaiksat) <snaik...@cisco.com> wrote: J I could do it, but I think someone like Tyler who has more familiarity with the code can do a better job. On seeing this thread, I did reach out to him and made that suggestion. Great. And Sumit, you can also get some brownie points (though not as many) for reviewing the much shorter OVS plugin patch :P https://code.launchpad.net/~danwent/quantum/lp834491/+merge/73002 If you haven't already, its probably worth making sure the Cisco plugin wasn't similarly affected by the tweaked assumptions in the new API code. Dan From: netstack-bounces+snaiksat=cisco....@lists.launchpad.net [mailto:netstack-bounces+snaiksat <mailto:netstack-bounces%2Bsnaiksat> =cisco....@lists.launchpad.net] On Behalf Of Salvatore Orlando Sent: Friday, August 26, 2011 1:31 AM To: Dan Wendlandt Cc: netstack@lists.launchpad.net Subject: Re: [Netstack] D-4 drop delayed: cli appears broken in trunk It looks Sumit is still around J From: Dan Wendlandt [mailto:d...@nicira.com] Sent: 26 August 2011 09:23 To: Salvatore Orlando Cc: netstack@lists.launchpad.net Subject: Re: [Netstack] D-4 drop delayed: cli appears broken in trunk On Fri, Aug 26, 2011 at 1:06 AM, Salvatore Orlando <salvatore.orla...@eu.citrix.com> wrote: Sorry about the broken CLI. Without unit tests, I did some manual tests, but unfortunately it seems my tests were not thorough enough. The revised-cli branch is already updated for API v1.0, and has unit tests which pass. As stated by Dan, a first review has already been done, and I'm addressing his comments. I'm quite confident we can get it merged today. Its a race to see how can get review #2 done.... lots of brownie points to the winner! :) Regards, Salvatore From: netstack-bounces+salvatore.orlando=eu.citrix....@lists.launchpad.net [mailto:netstack-bounces+salvatore.orlando <mailto:netstack-bounces%2Bsalvatore.orlando> =eu.citrix....@lists.launchpad.net] On Behalf Of Dan Wendlandt Sent: 26 August 2011 08:23 To: netstack@lists.launchpad.net Subject: [Netstack] D-4 drop delayed: cli appears broken in trunk Hi folks, Great work on all of the reviews folks. Unfortunately, with the flurry of activity, it seems like latest API changes seem to have broken the cli in trunk. Since the CLI is currently the main way an outsider would currently play with Quantum, it probably doesn't make much sense to create a D-4 drop were someone cannot perform basic operations like creating a network. We could fix the current cli.py (the problems seem to be fairly simple parameter renames), but I feel a better approach is probably just to quickly review Salvatore's new CLI branch that is based on cheetah templates, as that branch has unit tests that would have detected this issue in the first place. I have done a first review, but it would be great if at least one other person could take a look at this sometime on friday so we can get the code merged: https://code.launchpad.net/~salvatore-orlando/quantum/quantum-cli-revise d/+merge/72934 Thanks! Dan -- ~~~~~~~~~~~~~~~~~~~~~~~~~~~ Dan Wendlandt Nicira Networks, Inc. www.nicira.com | www.openvswitch.org Sr. Product Manager cell: 650-906-2650 ~~~~~~~~~~~~~~~~~~~~~~~~~~~ -- ~~~~~~~~~~~~~~~~~~~~~~~~~~~ Dan Wendlandt Nicira Networks, Inc. www.nicira.com | www.openvswitch.org Sr. Product Manager cell: 650-906-2650 ~~~~~~~~~~~~~~~~~~~~~~~~~~~ -- ~~~~~~~~~~~~~~~~~~~~~~~~~~~ Dan Wendlandt Nicira Networks, Inc. www.nicira.com | www.openvswitch.org Sr. Product Manager cell: 650-906-2650 ~~~~~~~~~~~~~~~~~~~~~~~~~~~
-- Mailing list: https://launchpad.net/~netstack Post to : netstack@lists.launchpad.net Unsubscribe : https://launchpad.net/~netstack More help : https://help.launchpad.net/ListHelp
