On Fri, Aug 26, 2011 at 1:06 AM, Salvatore Orlando < salvatore.orla...@eu.citrix.com> wrote:
> Sorry about the broken CLI. **** > > Without unit tests, I did some manual tests, but unfortunately it seems my > tests were not thorough enough.**** > > ** ** > > The revised-cli branch is already updated for API v1.0, and has unit tests > which pass. **** > > As stated by Dan, a first review has already been done, and I’m addressing > his comments. I’m quite confident we can get it merged today. > Its a race to see how can get review #2 done.... lots of brownie points to the winner! :) > **** > > ** ** > > Regards,**** > > Salvatore**** > > ** ** > > *From:* netstack-bounces+salvatore.orlando= > eu.citrix....@lists.launchpad.net [mailto: > netstack-bounces+salvatore.orlando=eu.citrix....@lists.launchpad.net] *On > Behalf Of *Dan Wendlandt > *Sent:* 26 August 2011 08:23 > *To:* netstack@lists.launchpad.net > *Subject:* [Netstack] D-4 drop delayed: cli appears broken in trunk**** > > ** ** > > Hi folks,**** > > ** ** > > Great work on all of the reviews folks. **** > > ** ** > > Unfortunately, with the flurry of activity, it seems like latest API > changes seem to have broken the cli in trunk. Since the CLI is currently > the main way an outsider would currently play with Quantum, it probably > doesn't make much sense to create a D-4 drop were someone cannot perform > basic operations like creating a network. **** > > ** ** > > We could fix the current cli.py (the problems seem to be fairly simple > parameter renames), but I feel a better approach is probably just to quickly > review Salvatore's new CLI branch that is based on cheetah templates, as > that branch has unit tests that would have detected this issue in the first > place. I have done a first review, but it would be great if at least one > other person could take a look at this sometime on friday so we can get the > code merged: > https://code.launchpad.net/~salvatore-orlando/quantum/quantum-cli-revised/+merge/72934 > **** > > ** ** > > Thanks!**** > > ** ** > > Dan**** > > ** ** > > ** ** > > > **** > > ** ** > > -- > ~~~~~~~~~~~~~~~~~~~~~~~~~~~ > Dan Wendlandt > Nicira Networks, Inc. > www.nicira.com | www.openvswitch.org > Sr. Product Manager > cell: 650-906-2650 > ~~~~~~~~~~~~~~~~~~~~~~~~~~~**** > -- ~~~~~~~~~~~~~~~~~~~~~~~~~~~ Dan Wendlandt Nicira Networks, Inc. www.nicira.com | www.openvswitch.org Sr. Product Manager cell: 650-906-2650 ~~~~~~~~~~~~~~~~~~~~~~~~~~~
-- Mailing list: https://launchpad.net/~netstack Post to : netstack@lists.launchpad.net Unsubscribe : https://launchpad.net/~netstack More help : https://help.launchpad.net/ListHelp
