From: Giuseppe Cavallaro <peppe.cavall...@st.com>

The dirty index can be updated out of the loop where all the
tx resources are claimed. This will help on performances too.
Also a useless debug printk has been removed from the main loop.

Signed-off-by: Giuseppe Cavallaro <peppe.cavall...@st.com>
Signed-off-by: Alexandre TORGUE <alexandre.tor...@st.com>

diff --git a/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c 
b/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c
index d31179f..2e4c10a 100644
--- a/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c
+++ b/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c
@@ -1340,9 +1340,6 @@ static void stmmac_tx_clean(struct stmmac_priv *priv)
                        }
                        stmmac_get_tx_hwtstamp(priv, entry, skb);
                }
-               if (netif_msg_tx_done(priv))
-                       pr_debug("%s: curr %d, dirty %d\n", __func__,
-                                priv->cur_tx, priv->dirty_tx);
 
                if (likely(priv->tx_skbuff_dma[entry].buf)) {
                        if (priv->tx_skbuff_dma[entry].map_as_page)
@@ -1372,8 +1369,8 @@ static void stmmac_tx_clean(struct stmmac_priv *priv)
                priv->hw->desc->release_tx_desc(p, priv->mode);
 
                entry = STMMAC_GET_ENTRY(entry, DMA_TX_SIZE);
-               priv->dirty_tx = entry;
        }
+       priv->dirty_tx = entry;
 
        netdev_completed_queue(priv->dev, pkts_compl, bytes_compl);
 
-- 
1.9.1

Reply via email to