From: Mahesh Bandewar <mah...@bandewar.net>
Date: Tue,  2 Feb 2016 11:20:30 -0800

> From: Mahesh Bandewar <mahe...@google.com>
> 
> The mode argument was erronusly defined as u32 but it has always
> been u16.
> 
> Signed-off-by: Mahesh Bandewar <mahe...@google.com>

This patch is changing more than this.

Specifically it is invoking ipvlan_set_port_mode() instead of assigning
port->mode directly in ipvlan_link_new().

That minimally needs to be documented in the commit log message.

But I also wonder if for some reason in this conect the direct
assignment happens to be fine.  That's pretty much why you should
explain things.

Reply via email to