From: Nikolay Aleksandrov <ra...@blackwall.org> Date: Tue, 17 Nov 2015 15:49:06 +0100
> From: Nikolay Aleksandrov <niko...@cumulusnetworks.com> > > This reverts commit 00ee59271777 ("net: fix __netdev_update_features return > on ndo_set_features failure") > and adds a comment explaining why it's okay to return a value other than > 0 upon error. Some drivers might actually change flags and return an > error so it's better to fire a spurious notification rather than miss > these. > > CC: Michał Mirosław <mirq-li...@rere.qmqm.pl> > Signed-off-by: Nikolay Aleksandrov <niko...@cumulusnetworks.com> > --- > Thanks to Michal for the explanation on why it was made to act like that. > Also sorry for the noise, unfortunately I missed this. IMO this should've > been an all or nothing op from the beginning. Applied. -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html