On Fri, Nov 13, 2015 at 03:20:24PM +0100, Nikolay Aleksandrov wrote: > From: Nikolay Aleksandrov <niko...@cumulusnetworks.com> > > If ndo_set_features fails __netdev_update_features() will return -1 but > this is wrong because it is expected to return 0 if no features were > changed (see netdev_update_features()), which will cause a netdev > notifier to be called without any actual changes. Fix this by returning > 0 if ndo_set_features fails.
Hmm. In case ndo_update_features() failed it might have changed the features. The assumption I made was that we're better off initiating spurious notification than miss one. This is an unlikely event - a bug in a driver or problem with the HW. Best Regards, Michał Mirosław -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
