On Thu, Aug 13, 2015 at 2:24 PM, Jesse Gross <[email protected]> wrote: > On Wed, Aug 12, 2015 at 4:33 PM, Pravin Shelar <[email protected]> wrote: >> On Wed, Aug 12, 2015 at 2:55 PM, Jesse Gross <[email protected]> wrote: >>> The farther I go in the series, the more that I hope that we can avoid >>> the use of collect_md_tun. It really seems to add a lot of special >>> cases. >> >> Use of collect_md_tun allows us to avoid hash table lookup. thats why >> I did it. Anyways we need a flag or pointer in geneve-sock structure >> to locate tunnel metadata. I dont see how is it simple if >> collect_md_tun is replaced with a flag. > > It seems to me that this requires more bookkeeping to keep consistent > (a little in the code but mostly mentally) because collect_md_tun is a > separate concept that doesn't necessarily follow the same rules as > other tunnels. With VXLAN, I feel like I can mostly ignore this tunnel > since it isn't special in most ways with the exception of places where > it actually needs to do something different like allocate metadata.
ok, I will update the patch. -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html
