On Wed, Aug 12, 2015 at 2:55 PM, Jesse Gross <je...@nicira.com> wrote:
> On Tue, Aug 11, 2015 at 10:17 PM, Pravin B Shelar <pshe...@nicira.com> wrote:
>> diff --git a/drivers/net/Kconfig b/drivers/net/Kconfig
>> index c18f9e6..0002ab7 100644
>> --- a/drivers/net/Kconfig
>> +++ b/drivers/net/Kconfig
>> @@ -181,7 +181,7 @@ config VXLAN
>>
>>  config GENEVE
>>         tristate "Generic Network Virtualization Encapsulation netdev"
>> -       depends on INET && GENEVE_CORE
>> +       depends on INET
>>         select NET_IP_TUNNEL
>
> I think this now needs to select NET_UDP_TUNNEL instead of NET_IP_TUNNEL.
>
ok.

> I would also drop "netdev" from the end of the title since there is no
> longer a split between the netdev and library.
>
ok.

> The farther I go in the series, the more that I hope that we can avoid
> the use of collect_md_tun. It really seems to add a lot of special
> cases.

Use of collect_md_tun allows us to avoid hash table lookup. thats why
I did it. Anyways we need a flag or pointer in geneve-sock structure
to locate tunnel metadata. I dont see how is it simple if
collect_md_tun is replaced with a flag.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Reply via email to