From: Sathya Perla <sathya.pe...@emulex.com> Date: Mon, 4 May 2015 02:47:17 -0400
> From: Kalesh AP <kalesh.pura...@emulex.com> > > The driver so far, on load, always tried to enable RX/TX general pause. > This setting always fails on certain profiles (like FCoE) where PFC is > needed. Such failures cannot be effectively communicated to the stack or > user. To fix this unpredictability in state, this patch changes the driver > behavior by not configuring pause at load time. > The user can configure it via ethtool and if the setting is disallowed, > an appropriate error is returned. > > Signed-off-by: Kalesh AP <kalesh.pura...@emulex.com> > Signed-off-by: Sathya Perla <sathya.pe...@emulex.com> Not enabling pause by default is going to be _STRONGLY_ not expected by the user and will cause unwanted packet drops in high traffic environments. It's not the user's fault that your stuff is architected in such a way such that handling this properly isn't easy. -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
