From: James Chapman <[EMAIL PROTECTED]>
Date: Thu, 6 Sep 2007 15:16:00 +0100

> First, do we need to encourage consistency in NAPI poll drivers? A
> survey of current NAPI drivers shows different strategies being used
> in their poll(). Some such as r8169 do the napi_complete() if poll()
> does less work than their allowed budget. Others such as e100 and
> tg3 do napi_complete() only if they do no work at all.

Actually, I want to clarify this situation.  In reality these
drivers are more consistent than different.

For some chips the cheapest way to figure out if there is more
RX work is simply to see if the amount of work processed is
less than "budget".  It's too expensive to recheck the hardware.

On some chips like tg3, it's extremely cheap to see if new work
arrived between the completion of processing the RX queue and
the NAPI completion check, so they do it.

But logically they are testing the same exact high level thing.
-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Reply via email to