On Wednesday 08 August 2007 14:55:11 Andi Kleen wrote: > On Wed, Aug 08, 2007 at 01:50:35PM +0200, Michael Buesch wrote: > > On Wednesday 08 August 2007 14:38:10 Andi Kleen wrote: > > > Jeff Garzik <[EMAIL PROTECTED]> writes: > > > > > + val, reg_index, addr, addr+4); */ > > > > > + writel(cpu_to_le32(reg_index), addr); > > > > > + writel(cpu_to_le32(val),(u8 *)addr + 4); > > > > > > > > wrong -- endian conversion macros not needed with writel() > > > > > > Are you sure? I don't think that's true. e.g. powerpc writel > > > doesn't convert endian > > > > Andi, you are wrong. > > writeX take CPU endian args. > > That is what I wrote.
Uhm, so.... Why did you complain to Jeff? I'm a little bit confused now :) Fact is that we do _not_ need cpu_to_le32 with writel. -- Greetings Michael. - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html
