On Wednesday 08 August 2007 15:48:25 Michael Buesch wrote: > > However if that's true then there are quite some drivers wrong: > > > > % grep -r write[bwl]\(cpu_to * | wc -l > > 57 > > Yeah, seems so.
Most of them seem to be __raw_writew(cpu_toXX(... which I think might be valid. But there are indeed a few cases that look wrong. arch/mips/pci/ops-bonito64.c: writel(cpu_to_le32(*data), addrp); arch/x86_64/kernel/pci-calgary.c: writel(cpu_to_be32(val), target); arch/x86_64/kernel/pci-calgary.c: writel(cpu_to_be32(val), target); arch/x86_64/kernel/pci-calgary.c: writel(cpu_to_be32(val32), target); arch/x86_64/kernel/pci-calgary.c: writel(cpu_to_be32(val), target); arch/x86_64/kernel/pci-calgary.c: writel(cpu_to_be32(val32), target); arch/x86_64/kernel/pci-calgary.c: writel(cpu_to_be32(val32), target); drivers/atm/fore200e.c: writel(cpu_to_le32(val), addr); drivers/net/starfire.c: writew(cpu_to_be16(eaddrs[2]), setup_frm); setup_frm += 4; drivers/net/starfire.c: writew(cpu_to_be16(eaddrs[1]), setup_frm); setup_frm += 4; drivers/net/starfire.c: writew(cpu_to_be16(eaddrs[0]), setup_frm); setup_frm += 8; drivers/net/starfire.c: writew(cpu_to_be16(i), filter_addr); drivers/net/starfire.c: writew(cpu_to_be16(eaddrs[2]), filter_addr); filter_addr += 4; drivers/net/starfire.c: writew(cpu_to_be16(eaddrs[1]), filter_addr); filter_addr += 4; drivers/net/starfire.c: writew(cpu_to_be16(eaddrs[0]), filter_addr); filter_addr += 8; drivers/net/starfire.c: writew(cpu_to_be16(eaddrs[0]), filter_addr); filter_addr += 4; drivers/net/starfire.c: writew(cpu_to_be16(eaddrs[1]), filter_addr); filter_addr += 4; drivers/net/starfire.c: writew(cpu_to_be16(eaddrs[2]), filter_addr); filter_addr += 8; drivers/net/starfire.c: writew(cpu_to_be16(eaddrs[0]), filter_addr); filter_addr += 4; drivers/net/starfire.c: writew(cpu_to_be16(eaddrs[1]), filter_addr); filter_addr += 4; drivers/net/starfire.c: writew(cpu_to_be16(eaddrs[2]), filter_addr); filter_addr += 8; drivers/net/hamachi.c: writel(cpu_to_le64(hmp->rx_ring_dma), ioaddr + RxPtr); drivers/net/hamachi.c: writel(cpu_to_le64(hmp->rx_ring_dma) >> 32, ioaddr + RxPtr + 4); drivers/net/hamachi.c: writel(cpu_to_le64(hmp->tx_ring_dma), ioaddr + TxPtr); drivers/net/hamachi.c: writel(cpu_to_le64(hmp->tx_ring_dma) >> 32, ioaddr + TxPtr + 4); drivers/net/hamachi.c: writel(cpu_to_le32(hmp->rx_ring_dma), ioaddr + RxPtr); drivers/net/hamachi.c: writel(cpu_to_le32(hmp->tx_ring_dma), ioaddr + TxPtr); drivers/net/tokenring/lanstreamer.c: writel(cpu_to_le32(pci_map_single(streamer_priv->pci_dev, rx_ring, 512, PCI_DMA_FROMDEVICE)), drivers/net/tokenring/lanstreamer.c: writel(cpu_to_le32(pci_map_single(streamer_priv->pci_dev, &streamer_priv->streamer_rx_ring[0], drivers/net/tokenring/lanstreamer.c: writel(cpu_to_le32(pci_map_single(streamer_priv->pci_dev, &streamer_priv->streamer_rx_ring[STREAMER_RX_RING_SIZE - 1], drivers/net/tokenring/lanstreamer.c: writel(cpu_to_le32(pci_map_single(streamer_priv->pci_dev, drivers/net/tokenring/lanstreamer.c: writel(cpu_to_le32(pci_map_single(streamer_priv->pci_dev, drivers/net/tokenring/lanstreamer.c: writel(cpu_to_le32(pci_map_single(streamer_priv->pci_dev, drivers/net/via-velocity.c: writel(cpu_to_le32(vptr->rd_pool_dma), ®s->RDBaseLo); drivers/net/via-velocity.c: writel(cpu_to_le32(vptr->td_pool_dma[i]), &(regs->TDBaseLo[i])); drivers/scsi/nsp32_io.h: writew(cpu_to_le16(val), ptr); drivers/scsi/nsp32_io.h: writel(cpu_to_le32(val), ptr); drivers/scsi/nsp32_io.h: writew(cpu_to_le16(val), data_ptr ); drivers/block/umem.c: writel(cpu_to_le32((page->page_dma+offset)&0xffffffff), drivers/block/umem.c: writel(cpu_to_le32(((u64)page->page_dma)>>32), drivers/block/umem.c: writel(cpu_to_le32(DMASCR_GO | DMASCR_CHAIN_EN | pci_cmds), drivers/block/umem.c: writel(cpu_to_le32(DMASCR_DMA_COMPLETE|DMASCR_CHAIN_COMPLETE), -- Greetings Michael. - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html
