On Mon, Jul 02, 2007 at 02:09:58PM -0700, Stephen Hemminger wrote: > The patch is close to ready for 2.6.24 when this driver will need to show up.
If intel manages to fix up the reamining issues I'd rather see it appear in 2.6.23.. > Since I know Intel will be forced to backport this to older distro's. You > would be best to have a single receive queue version when you have to make > it work on the older code. But that'll require the single receiver queue version I guess. The netdevice abuse is the only really major issue I see, although I'd of course really like to see the driver getting rid of the bitfield abuse aswell. > > Since we wanted to distinguish the various MSIX vectors in > > /proc/interrupts and since request_irq expects memory for name to be > > allocated somewhere, I added this part of the ring struct. > > You only need to store the name for when you are doing request_irq, so > it can just be a stack temporary. Lots of drivers where the interface name is assigned after request_irq just use an internal name, e.g. ixgbeX in the case of this driver. - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html
