Hi Parav, Thank you for the patch! Yet something to improve:
[auto build test ERROR on net-next/master] url: https://github.com/0day-ci/linux/commits/Parav-Pandit/netdevsim-port-add-delete-support/20210206-210153 base: https://git.kernel.org/pub/scm/linux/kernel/git/davem/net-next.git 6626a0266566c5aea16178c5e6cd7fc4db3f2f56 config: x86_64-allyesconfig (attached as .config) compiler: gcc-9 (Debian 9.3.0-15) 9.3.0 reproduce (this is a W=1 build): # https://github.com/0day-ci/linux/commit/4234edd1adbb2da7f6f156c2bfdac5170eb97dbb git remote add linux-review https://github.com/0day-ci/linux git fetch --no-tags linux-review Parav-Pandit/netdevsim-port-add-delete-support/20210206-210153 git checkout 4234edd1adbb2da7f6f156c2bfdac5170eb97dbb # save the attached .config to linux build tree make W=1 ARCH=x86_64 If you fix the issue, kindly add following tag as appropriate Reported-by: kernel test robot <l...@intel.com> All errors (new ones prefixed by >>): In file included from drivers/net/netdevsim/dev.c:36: drivers/net/netdevsim/netdevsim.h:317:23: warning: 'struct devlink_port_new_attrs' declared inside parameter list will not be visible outside of this definition or declaration 317 | const struct devlink_port_new_attrs *attrs, | ^~~~~~~~~~~~~~~~~~~~~~ >> drivers/net/netdevsim/dev.c:908:3: error: 'const struct devlink_ops' has no >> member named 'port_new' 908 | .port_new = nsim_dev_devlink_port_new, | ^~~~~~~~ >> drivers/net/netdevsim/dev.c:908:14: error: initialization of 'int (*)(struct >> devlink *, struct devlink_port *, u8 *, int *, struct netlink_ext_ack *)' >> {aka 'int (*)(struct devlink *, struct devlink_port *, unsigned char *, int >> *, struct netlink_ext_ack *)'} from incompatible pointer type 'int >> (*)(struct devlink *, const struct devlink_port_new_attrs *, struct >> netlink_ext_ack *, unsigned int *)' [-Werror=incompatible-pointer-types] 908 | .port_new = nsim_dev_devlink_port_new, | ^~~~~~~~~~~~~~~~~~~~~~~~~ drivers/net/netdevsim/dev.c:908:14: note: (near initialization for 'nsim_dev_devlink_ops.port_function_hw_addr_get') >> drivers/net/netdevsim/dev.c:909:3: error: 'const struct devlink_ops' has no >> member named 'port_del'; did you mean 'port_split'? 909 | .port_del = nsim_dev_devlink_port_del, | ^~~~~~~~ | port_split >> drivers/net/netdevsim/dev.c:909:14: error: initialization of 'int (*)(struct >> devlink *, struct devlink_port *, const u8 *, int, struct netlink_ext_ack >> *)' {aka 'int (*)(struct devlink *, struct devlink_port *, const unsigned >> char *, int, struct netlink_ext_ack *)'} from incompatible pointer type >> 'int (*)(struct devlink *, unsigned int, struct netlink_ext_ack *)' >> [-Werror=incompatible-pointer-types] 909 | .port_del = nsim_dev_devlink_port_del, | ^~~~~~~~~~~~~~~~~~~~~~~~~ drivers/net/netdevsim/dev.c:909:14: note: (near initialization for 'nsim_dev_devlink_ops.port_function_hw_addr_set') cc1: some warnings being treated as errors vim +908 drivers/net/netdevsim/dev.c 894 895 static const struct devlink_ops nsim_dev_devlink_ops = { 896 .supported_flash_update_params = DEVLINK_SUPPORT_FLASH_UPDATE_COMPONENT | 897 DEVLINK_SUPPORT_FLASH_UPDATE_OVERWRITE_MASK, 898 .reload_actions = BIT(DEVLINK_RELOAD_ACTION_DRIVER_REINIT), 899 .reload_down = nsim_dev_reload_down, 900 .reload_up = nsim_dev_reload_up, 901 .info_get = nsim_dev_info_get, 902 .flash_update = nsim_dev_flash_update, 903 .trap_init = nsim_dev_devlink_trap_init, 904 .trap_action_set = nsim_dev_devlink_trap_action_set, 905 .trap_group_set = nsim_dev_devlink_trap_group_set, 906 .trap_policer_set = nsim_dev_devlink_trap_policer_set, 907 .trap_policer_counter_get = nsim_dev_devlink_trap_policer_counter_get, > 908 .port_new = nsim_dev_devlink_port_new, > 909 .port_del = nsim_dev_devlink_port_del, 910 }; 911 --- 0-DAY CI Kernel Test Service, Intel Corporation https://lists.01.org/hyperkitty/list/kbuild-...@lists.01.org
.config.gz
Description: application/gzip
