Hi Parav, Thank you for the patch! Perhaps something to improve:
[auto build test WARNING on net-next/master] url: https://github.com/0day-ci/linux/commits/Parav-Pandit/netdevsim-port-add-delete-support/20210206-210153 base: https://git.kernel.org/pub/scm/linux/kernel/git/davem/net-next.git 6626a0266566c5aea16178c5e6cd7fc4db3f2f56 config: x86_64-allyesconfig (attached as .config) compiler: gcc-9 (Debian 9.3.0-15) 9.3.0 reproduce (this is a W=1 build): # https://github.com/0day-ci/linux/commit/4234edd1adbb2da7f6f156c2bfdac5170eb97dbb git remote add linux-review https://github.com/0day-ci/linux git fetch --no-tags linux-review Parav-Pandit/netdevsim-port-add-delete-support/20210206-210153 git checkout 4234edd1adbb2da7f6f156c2bfdac5170eb97dbb # save the attached .config to linux build tree make W=1 ARCH=x86_64 If you fix the issue, kindly add following tag as appropriate Reported-by: kernel test robot <l...@intel.com> All warnings (new ones prefixed by >>): In file included from drivers/net/netdevsim/netdev.c:27: >> drivers/net/netdevsim/netdevsim.h:317:23: warning: 'struct >> devlink_port_new_attrs' declared inside parameter list will not be visible >> outside of this definition or declaration 317 | const struct devlink_port_new_attrs *attrs, | ^~~~~~~~~~~~~~~~~~~~~~ -- In file included from drivers/net/netdevsim/dev.c:36: >> drivers/net/netdevsim/netdevsim.h:317:23: warning: 'struct >> devlink_port_new_attrs' declared inside parameter list will not be visible >> outside of this definition or declaration 317 | const struct devlink_port_new_attrs *attrs, | ^~~~~~~~~~~~~~~~~~~~~~ drivers/net/netdevsim/dev.c:908:3: error: 'const struct devlink_ops' has no member named 'port_new' 908 | .port_new = nsim_dev_devlink_port_new, | ^~~~~~~~ drivers/net/netdevsim/dev.c:908:14: error: initialization of 'int (*)(struct devlink *, struct devlink_port *, u8 *, int *, struct netlink_ext_ack *)' {aka 'int (*)(struct devlink *, struct devlink_port *, unsigned char *, int *, struct netlink_ext_ack *)'} from incompatible pointer type 'int (*)(struct devlink *, const struct devlink_port_new_attrs *, struct netlink_ext_ack *, unsigned int *)' [-Werror=incompatible-pointer-types] 908 | .port_new = nsim_dev_devlink_port_new, | ^~~~~~~~~~~~~~~~~~~~~~~~~ drivers/net/netdevsim/dev.c:908:14: note: (near initialization for 'nsim_dev_devlink_ops.port_function_hw_addr_get') drivers/net/netdevsim/dev.c:909:3: error: 'const struct devlink_ops' has no member named 'port_del'; did you mean 'port_split'? 909 | .port_del = nsim_dev_devlink_port_del, | ^~~~~~~~ | port_split drivers/net/netdevsim/dev.c:909:14: error: initialization of 'int (*)(struct devlink *, struct devlink_port *, const u8 *, int, struct netlink_ext_ack *)' {aka 'int (*)(struct devlink *, struct devlink_port *, const unsigned char *, int, struct netlink_ext_ack *)'} from incompatible pointer type 'int (*)(struct devlink *, unsigned int, struct netlink_ext_ack *)' [-Werror=incompatible-pointer-types] 909 | .port_del = nsim_dev_devlink_port_del, | ^~~~~~~~~~~~~~~~~~~~~~~~~ drivers/net/netdevsim/dev.c:909:14: note: (near initialization for 'nsim_dev_devlink_ops.port_function_hw_addr_set') cc1: some warnings being treated as errors -- In file included from drivers/net/netdevsim/port_function.c:7: >> drivers/net/netdevsim/netdevsim.h:317:23: warning: 'struct >> devlink_port_new_attrs' declared inside parameter list will not be visible >> outside of this definition or declaration 317 | const struct devlink_port_new_attrs *attrs, | ^~~~~~~~~~~~~~~~~~~~~~ drivers/net/netdevsim/port_function.c:51:20: warning: 'struct devlink_port_new_attrs' declared inside parameter list will not be visible outside of this definition or declaration 51 | const struct devlink_port_new_attrs *attrs) | ^~~~~~~~~~~~~~~~~~~~~~ drivers/net/netdevsim/port_function.c: In function 'nsim_devlink_port_fn_alloc': drivers/net/netdevsim/port_function.c:71:23: error: dereferencing pointer to incomplete type 'const struct devlink_port_new_attrs' 71 | port->flavour = attrs->flavour; | ^~ drivers/net/netdevsim/port_function.c: At top level: drivers/net/netdevsim/port_function.c:130:19: warning: 'struct devlink_port_new_attrs' declared inside parameter list will not be visible outside of this definition or declaration 130 | const struct devlink_port_new_attrs *attrs) | ^~~~~~~~~~~~~~~~~~~~~~ drivers/net/netdevsim/port_function.c: In function 'nsim_dev_port_port_exists': drivers/net/netdevsim/port_function.c:135:12: error: dereferencing pointer to incomplete type 'const struct devlink_port_new_attrs' 135 | if (attrs->port_index_valid && | ^~ drivers/net/netdevsim/port_function.c: At top level: drivers/net/netdevsim/port_function.c:201:18: warning: 'struct devlink_port_new_attrs' declared inside parameter list will not be visible outside of this definition or declaration 201 | const struct devlink_port_new_attrs *attrs) | ^~~~~~~~~~~~~~~~~~~~~~ drivers/net/netdevsim/port_function.c: In function 'nsim_dev_port_flavour_supported': drivers/net/netdevsim/port_function.c:203:14: error: dereferencing pointer to incomplete type 'const struct devlink_port_new_attrs' 203 | return attrs->flavour == DEVLINK_PORT_FLAVOUR_PCI_PF; | ^~ drivers/net/netdevsim/port_function.c: At top level: drivers/net/netdevsim/port_function.c:207:23: warning: 'struct devlink_port_new_attrs' declared inside parameter list will not be visible outside of this definition or declaration 207 | const struct devlink_port_new_attrs *attrs, | ^~~~~~~~~~~~~~~~~~~~~~ drivers/net/netdevsim/port_function.c:206:5: error: conflicting types for 'nsim_dev_devlink_port_new' 206 | int nsim_dev_devlink_port_new(struct devlink *devlink, | ^~~~~~~~~~~~~~~~~~~~~~~~~ In file included from drivers/net/netdevsim/port_function.c:7: drivers/net/netdevsim/netdevsim.h:316:5: note: previous declaration of 'nsim_dev_devlink_port_new' was here 316 | int nsim_dev_devlink_port_new(struct devlink *devlink, | ^~~~~~~~~~~~~~~~~~~~~~~~~ drivers/net/netdevsim/port_function.c: In function 'nsim_dev_devlink_port_new': drivers/net/netdevsim/port_function.c:217:11: error: dereferencing pointer to incomplete type 'const struct devlink_port_new_attrs' 217 | if (attrs->port_index_valid && | ^~ drivers/net/netdevsim/port_function.c:223:49: error: passing argument 2 of 'nsim_dev_port_flavour_supported' from incompatible pointer type [-Werror=incompatible-pointer-types] 223 | if (!nsim_dev_port_flavour_supported(nsim_dev, attrs)) { | ^~~~~ | | | const struct devlink_port_new_attrs * drivers/net/netdevsim/port_function.c:201:42: note: expected 'const struct devlink_port_new_attrs *' but argument is of type 'const struct devlink_port_new_attrs *' 201 | const struct devlink_port_new_attrs *attrs) | ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~^~~~~ drivers/net/netdevsim/port_function.c:232:42: error: passing argument 2 of 'nsim_dev_port_port_exists' from incompatible pointer type [-Werror=incompatible-pointer-types] 232 | if (nsim_dev_port_port_exists(nsim_dev, attrs)) { | ^~~~~ | | | const struct devlink_port_new_attrs * drivers/net/netdevsim/port_function.c:130:43: note: expected 'const struct devlink_port_new_attrs *' but argument is of type 'const struct devlink_port_new_attrs *' 130 | const struct devlink_port_new_attrs *attrs) | ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~^~~~~ drivers/net/netdevsim/port_function.c:238:46: error: passing argument 2 of 'nsim_devlink_port_fn_alloc' from incompatible pointer type [-Werror=incompatible-pointer-types] 238 | port = nsim_devlink_port_fn_alloc(nsim_dev, attrs); | ^~~~~ | | | const struct devlink_port_new_attrs * drivers/net/netdevsim/port_function.c:51:44: note: expected 'const struct devlink_port_new_attrs *' but argument is of type 'const struct devlink_port_new_attrs *' 51 | const struct devlink_port_new_attrs *attrs) | ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~^~~~~ drivers/net/netdevsim/port_function.c: In function 'nsim_dev_devlink_port_del': drivers/net/netdevsim/port_function.c:269:6: warning: variable 'err' set but not used [-Wunused-but-set-variable] 269 | int err = 0; | ^~~ drivers/net/netdevsim/port_function.c: In function 'nsim_dev_port_flavour_supported': drivers/net/netdevsim/port_function.c:204:1: error: control reaches end of non-void function [-Werror=return-type] 204 | } | ^ cc1: some warnings being treated as errors vim +317 drivers/net/netdevsim/netdevsim.h 311 312 void nsim_dev_port_fn_init(struct nsim_dev *nsim_dev); 313 void nsim_dev_port_fn_exit(struct nsim_dev *nsim_dev); 314 void nsim_dev_port_fn_enable(struct nsim_dev *nsim_dev); 315 void nsim_dev_port_fn_disable(struct nsim_dev *nsim_dev); 316 int nsim_dev_devlink_port_new(struct devlink *devlink, > 317 const struct devlink_port_new_attrs > *attrs, --- 0-DAY CI Kernel Test Service, Intel Corporation https://lists.01.org/hyperkitty/list/kbuild-...@lists.01.org
.config.gz
Description: application/gzip
