On Fri, 29 Jan 2021 21:00:02 -0500 Willem de Bruijn wrote: > On Fri, Jan 29, 2021 at 7:09 PM Jacob Keller <jacob.e.kel...@intel.com> wrote: > > Yea this might re-introduce the issue described in that commit. However > > I believe the bug in question was due to very old versions of VF > > drivers, (including an ancient version of FreeBSD if I recall). > > > > Perhaps there is some better mechanism for handling this, but I think > > reverting this is ok given that it causes problems in certain situations > > where the link status wasn't reported properly. > > > > Maybe there is a solution for both cases? but I would worry less about > > an issue with the incredibly old VFs because we know that the issue is > > fixed in newer VF code and the real problem is that the VF driver is > > incorrectly assuming link up means it is ready to send. > > > > Thus, I am comfortable with this revert: It simplifies the state for > > both the PF and VF. > > > > I would be open to alternatives as long as the issue described here is > > also fixed. > > > > Caveat: I was not involved in the decision to revert this and wasn't > > aware of it until now, so I almost certainly have out of date information. > > That's reasonable. The original patch is over three years old. > > If it is considered safe to revert now, I would just articulate that > point in the commit.
Agreed. I'd call out that the original fix was a work around for clearly buggy client drivers, and they had enough time to be fixed.
